Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expandable section): update to use <Button> for toggle #10891

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix(expandable section): update to use <Button> for toggle #10891

merged 3 commits into from
Sep 5, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Aug 28, 2024

What: Closes #10878

@tlabaj tlabaj requested review from a team, wise-king-sullyman, kmcfaul and mattnolting and removed request for a team August 28, 2024 19:35
@tlabaj tlabaj linked an issue Aug 28, 2024 that may be closed by this pull request
Expandable section - update to use <Button> for toggle #10878
Closed
thatblindgeye
thatblindgeye reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cypress tests just need to be updated, most likely due to the expandable-section__toggle class now being a div that contains a button

@tlabaj tlabaj marked this pull request as draft August 29, 2024 14:53
@tlabaj tlabaj marked this pull request as ready for review August 30, 2024 13:46
@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 30, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10891.surge.sh

A11y report: https://patternfly-react-pr-10891-a11y.surge.sh

mcoker
mcoker approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dlabaj dlabaj merged commit fd9ce14 into patternfly:main Sep 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@mcoker mcoker mcoker approved these changes

@dlabaj dlabaj dlabaj approved these changes

@wise-king-sullyman wise-king-sullyman Awaiting requested review from wise-king-sullyman wise-king-sullyman was automatically assigned from patternfly/react-reviewers

@mattnolting mattnolting Awaiting requested review from mattnolting mattnolting was automatically assigned from patternfly/core-in-react-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expandable section - update to use <Button> for toggle
6 participants
@tlabaj @patternfly-build @dlabaj @mcoker @kmcfaul @thatblindgeye