Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test error: Modal being returned by getByLabelText queries when it shouldn't #11011

Closed
wise-king-sullyman opened this issue Sep 17, 2024 · 0 comments · Fixed by #11012
Closed
Assignees

Comments

@wise-king-sullyman
Copy link
Contributor

wise-king-sullyman commented Sep 17, 2024

Please describe the issue
In Koku we're seeing Modal being returned by getByLabelText queries when it isn't labelled with the query term and wasn't returned with the old label. Specifically it appears that when a modal has an aria-label it's setting the aria-labelledby automatically in a way that is self referential and causes it to turn up in queries that it shouldn't.

Are there visuals for this issue? Please provide screenshots
Include screenshots or links to Marvel or other mockups.
image

Could you point to a branch or draft PR where this issue exists? Please provide a link to the code

One example query: https://github.com/dlabrecq/koku-ui/blob/3be30d4579ecd3d9fff9693b42e03f990d906df4/src/routes/settings/costModels/costModel/updateRateModel.test.tsx#L332

Any other information?

Discovered while working on #10926. CC @dlabrecq for awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant