fix(Modal): Prevent auto aria-labelledby if aria-label is passed #11012
Conversation
|
Preview: https://patternfly-react-pr-11012.surge.sh A11y report: https://patternfly-react-pr-11012-a11y.surge.sh |
| if (boxId) { | ||
| idRefList.push(boxId); | ||
| } | ||
| if (ariaLabelledby) { | ||
| idRefList.push(ariaLabelledby); |
There was a problem hiding this comment.
We may want to only allow either boxId or aria-labelledby to be pushed to idRefList, not both. Right now the pf-v6-c-modal-box wrapper element may have extraneous labeling if an aria-labelledby is passed and that value references an element inside the Modal (like the basic modal example is doing).
So right now in that basic example, the accessible name of the dialog is everything in it, followed by its title (which is already announced). Having the boxId act as a fallback if both aria-label and aria-labelledby are missing would work better. Another thing, though, is that the check we're doing in the Modal code (~line 135) isn't really necessary, because if a consumer doesn't pass an ID to the Modal then we're constructing it, so we're always applying an aria-labelledby.
Unless I'm missing a case where that boxId would actually never be a valid value and aria-labelledby wouldn't automatically be applied or anything.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #11011
Additional issues: