Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masthead: add demo that includes horizontal nav #10241

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Masthead: add demo that includes horizontal nav #10241

merged 8 commits into from
Jun 10, 2024

Conversation

ajaypratap003
Copy link
Member

What: Closes #6826
Masthead: add demo that includes horizontal nav

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 3, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10241.surge.sh

A11y report: https://patternfly-react-pr-10241-a11y.surge.sh

@tlabaj tlabaj requested review from a team, mmenestr and mattnolting and removed request for a team April 17, 2024 13:46
wise-king-sullyman
wise-king-sullyman reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One question I have, I wonder if we would want to remove all of the logic for the search input and the favoriting and everything? It seems like it isn't really the focus of this demo and it seems to take up about half of the file.

wise-king-sullyman
wise-king-sullyman approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tlabaj
Copy link
Contributor

tlabaj commented Apr 24, 2024

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@ajaypratap003
Copy link
Member Author

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@tlabaj Can you please share the commit which is related to this PR

@tlabaj
Copy link
Contributor

tlabaj commented Apr 25, 2024

@ajaypratap003 this demo was recently added to the v6 branch. Perhaps you could cherry pick that commit, or you could make sure they align.

@tlabaj Can you please share the commit which is related to this PR

@ajaypratap003 Nevermind. I was mistaken. it was a Nav example that was added.

@ajaypratap003
Copy link
Member Author

@tlabaj Can you please merge this PR if everything look good.

@andrew-ronaldson andrew-ronaldson self-requested a review April 30, 2024 15:33
andrew-ronaldson
andrew-ronaldson approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

mattnolting
mattnolting requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks like you need to add toolbar to .pf-v5-c-masthead__content.

Screenshot 2024-04-30 at 1 32 47 PM

@ajaypratap003
Copy link
Member Author

Nice work! Looks like you need to add toolbar to .pf-v5-c-masthead__content.

Screenshot 2024-04-30 at 1 32 47 PM

@mattnolting Sorry, I don't get this point. Can you please describe bit more

kmcfaul
kmcfaul approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattnolting Can you explain a bit more what your requested change is? The masthead content does contain the toolbar.

@mattnolting
Copy link
Contributor

@kmcfaul @ajaypratap003
From: https://www.patternfly.org/components/masthead/html-demos/horizontal-nav/

Screenshot 2024-05-08 at 12 44 27 PM

@ajaypratap003 ajaypratap003 requested a review from mattnolting May 8, 2024 17:53
mattnolting
mattnolting requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nav goes inside a toolbar__item with the class pf-m-overflow-container

Current

Screenshot 2024-05-08 at 2 20 31 PM

update
Screenshot 2024-05-08 at 2 20 19 PM

@ajaypratap003
Copy link
Member Author

nav goes inside a toolbar__item with the class pf-m-overflow-container

Current

Screenshot 2024-05-08 at 2 20 31 PM **update** Screenshot 2024-05-08 at 2 20 19 PM

nav is already inside toolbar_item. this is the latest commit 525f4a7

@ajaypratap003 ajaypratap003 requested a review from mattnolting May 12, 2024 14:14
@mattnolting
Copy link
Contributor

nav goes inside a toolbar__item with the class pf-m-overflow-container
Current
Screenshot 2024-05-08 at 2 20 31 PM
update Screenshot 2024-05-08 at 2 20 19 PM

nav is already inside toolbar_item. this is the latest commit 525f4a7

Still can't see these.

This private-user-images.githubusercontent.com page can’t be found

mattnolting
mattnolting reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, need to include nav in a single toolbar

packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx Outdated Show resolved Hide resolved
packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx Show resolved Hide resolved
packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx Outdated Show resolved Hide resolved
packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx Outdated Show resolved Hide resolved
@ajaypratap003 ajaypratap003 requested a review from mattnolting June 8, 2024 14:58
mattnolting
mattnolting approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks like you got it all 👍

@tlabaj tlabaj merged commit c11cc53 into patternfly:main Jun 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mattnolting mattnolting mattnolting approved these changes

@mmenestr mmenestr Awaiting requested review from mmenestr mmenestr was automatically assigned from patternfly/ux-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Masthead: add demo that includes horizontal nav
8 participants
@ajaypratap003 @patternfly-build @tlabaj @mattnolting @wise-king-sullyman @andrew-ronaldson @kmcfaul @thatblindgeye