chore(ci): refactor CI and upgrade actions #10294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10294.surge.sh A11y report: https://patternfly-react-pr-10294-a11y.surge.sh |
jonkoops
changed the title
jonkoops
force-pushed
the
upgrade-ci
branch
2 times, most recently
from
d090156 to
d006998
Compare
jonkoops
commented
Apr 23, 2024
| @@ -77,9 +77,9 @@ | |||
| "clean:build": "rimraf .cache .eslintcache coverage", | |||
| "clean:exports": "lerna run clean:exports --parallel --stream", | |||
| "generate": "yarn plop", | |||
| "lint": "node --max-old-space-size=4096 node_modules/.bin/eslint --ext js,jsx,ts,tsx --cache", | |||
| "lint": "node --max-old-space-size=4096 node_modules/.bin/eslint --ext js,jsx,ts,tsx --cache --cache-strategy content", | |||
There was a problem hiding this comment.
Since Git doesn't track timestamps on files for modifications, the linter cache would not work. I've set this to check the file contents instead, which is slower, but will actually hit the cache.
jonkoops
commented
Apr 24, 2024
Comment on lines
-11
to
-14
| const owner = process.env.CIRCLE_PROJECT_USERNAME || ghrepo.split('/')[0]; // patternfly | ||
| const repo = process.env.CIRCLE_PROJECT_REPONAME || ghrepo.split('/')[1]; | ||
| const prnum = process.env.CIRCLE_PR_NUMBER || process.env.GH_PR_NUM; | ||
| const prbranch = process.env.CIRCLE_BRANCH || process.env.GITHUB_REF.split('/').pop(); |
There was a problem hiding this comment.
Circle CI isn't used anymore, so I've removed references to environment variables related to it.
Signed-off-by: Jon Koops <[email protected]>
wise-king-sullyman
approved these changes
Apr 26, 2024
|
Thanks y'all! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the PR preview action into two distinct actions, one to build and deploy the documentation for the PR, and another to do the CI tasks such as linting, testing and building. The latter workflow no longer requires the
pull_request_targetto run, which limits access to repository secrets.These workflows are now use a composite action to take care of the repetitive task of setting up Node.js, installing dependencies and running the build. The release workflow has been converted to re-use the CI and documentation workflows to reduce duplication.
I've ran the CI on this on my fork for testing, which you can see the result of here:
Push on
mainCI — https://github.com/jonkoops/patternfly-react/actions/runs/8819259805
Release (includes docs) — https://github.com/jonkoops/patternfly-react/actions/runs/8819259882
Pull request
CI — https://github.com/jonkoops/patternfly-react/actions/runs/8819461879
Documentation — https://github.com/jonkoops/patternfly-react/actions/runs/8819461789/job/24210724184