docs(Page): add example showing different type prop variants #10352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamviktora
requested review from
a team,
wise-king-sullyman and
nicolethoen
and removed request for
a team
|
Preview: https://patternfly-react-pr-10352.surge.sh A11y report: https://patternfly-react-pr-10352-a11y.surge.sh |
There was a problem hiding this comment.
Just to note: it seems like our preview builds are having issues, I didn't see this example on the preview but I did see it locally. That local build did show some compilation warnings, but I'm guessing those aren't related to this PR.
It looks like the example is missing the -group section that exists in the core version, but I see that seems to be missing as an option of PageSection so that could be done under a different issue IMO.
Other than wanting that addressed or a followup created and issues brought up in the PR body LGTM, happy to approve once those are resolved.
wise-king-sullyman
requested review from
a team and
mattnolting
and removed request for
a team
|
Yeah, the example is missing in the preview for some reason. In all the new branches I base on current 
I don't know if it is related to why the example is not showing in the preview though. About the |
nicolethoen
approved these changes
May 22, 2024
|
#10416 should fix this problem, let's do a rebase of this PR to see if it resolves the issue. |
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 17, 2024
…fly#10352) * docs(Page): add example showing different type prop variants * docs(Page): make text color white in "subnav" section * docs(Page): rename IDs in example
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 17, 2024
…fly#10352) * docs(Page): add example showing different type prop variants * docs(Page): make text color white in "subnav" section * docs(Page): rename IDs in example
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 24, 2024
…fly#10352) * docs(Page): add example showing different type prop variants * docs(Page): make text color white in "subnav" section * docs(Page): rename IDs in example
tlabaj
pushed a commit
to tlabaj/patternfly-react
that referenced
this pull request
Jun 25, 2024
…fly#10352) * docs(Page): add example showing different type prop variants * docs(Page): make text color white in "subnav" section * docs(Page): rename IDs in example
gitdallas
pushed a commit
that referenced
this pull request
Jun 25, 2024
* docs(Page): add example showing different type prop variants (#10352) * docs(Page): add example showing different type prop variants * docs(Page): make text color white in "subnav" section * docs(Page): rename IDs in example * docs(Table): update column management example to use link button for Cancel action (#10459) * feat(Modal): support ReactNode type for 'title' prop * fix(DatePicker/CalendarMonth): better range styling when some dates are disabled (#10398) * fix(DatePicker/CalendarMonth): range styling when disabled dates * chore(Datepicker): getElementSelectorToFocus function description * feat(MenuToggle): add OUIA support * docs(menu-toggle): Adds docs for split button examples. (#10268) * docs(menu-toggle): Adds docs for split button examples. * Update names of split toggle examples. * Add description list basic demo (#10184) * add description list basic demo * fix DashboardWrapper not found issue * implement review comments * add divider and size * update content * fixed layout issues * Convert demo application to Vite * Upgrade Testing Library dependencies to latest version * upgrade to latest version * upgrade to latest version * upgrade to latest version * chore(deps): replace camel-case with change-case * Masthead: add demo that includes horizontal nav * chore: use protocol for workspace dependencies * chore(deps): upgrade to the latest version * chore(deps): upgrade to the latest version * chore(deps): upgrade to the latest version * chore(deps): remove unused dependency * chore(deps): upgrade to the latest version * chore(deps): ugprade Jest to latest version * chore(deps): upgrade to the latest version * chore(deps): upgrade dependencies to the latest version * chore(deps): upgrade to the latest version * chore(deps): update dependencies * update yarn file * more deps fixes * more deps * fix(build): get our custom TS transformers working again (#10477) * fix(build): get our custom TS transformers working again * chore(deps): Update lock file * Update lock file * chore(deps): Update yarn lock * fix demo app * cherry pick yarn changes * update yarn.lock * updatw snapshots * fix demo app * feat(templates): toggle props & improvements (#10473) * feat(templates): toggle props & improvements * remove toggleContent from typeahead template * update template names * update tests * added SimpleSelect tests * fix yarnlock * fix(CodeEditor) support Mac and PC shortcuts in example (#10472) * updatee lock file --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Ajay Pratap <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Dominik Petřík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9868
Additional issues:
Section with type="nav" for tertiary navigation: thetertiarynavigation was removed in V6, we should rename it in the upcoming React example for V6 and the Core V6 example too - but what is thetype="nav"used for in V6 if not tertiary navigation?