Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): clean up demos - Timestamp date prop, icon status colors #10471

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

adamviktora
Copy link
Contributor

@adamviktora adamviktora commented May 29, 2024

Closes #10239 and #10238 (which is a duplicate)

  • also deleted ComposableDateSelect.tsx because the example was not used anywhere
  • replaced Timestamp with small in TableNestedHeader examples, because it was not used for date/time purposes

Additional issues spotted:

@patternfly-build
Copy link
Contributor

patternfly-build commented May 29, 2024

@adamviktora adamviktora changed the title fix(misc): pass correct date prop to Timestamp fix(misc): clean up demos - Timestamp date prop, icon status colors May 29, 2024
@adamviktora adamviktora linked an issue May 29, 2024 that may be closed by this pull request
@adamviktora adamviktora requested review from a team, nicolethoen and kmcfaul and removed request for a team May 29, 2024 14:26
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@nicolethoen nicolethoen merged commit 8c1d97b into patternfly:v6 Jun 11, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V6 Demos - date time
4 participants