Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Toolbar): replaced chip instances with label #10649

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Jun 25, 2024

What: Closes #10405

Codemod issue: patternfly/pf-codemods#673

Additional issues:

@thatblindgeye thatblindgeye linked an issue Jun 25, 2024 that may be closed by this pull request
@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 25, 2024

Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, changes lgtm. It was a little beyond the scope of the initial chip replacement work, hence the follow up issue.

@tlabaj
Copy link
Contributor

tlabaj commented Jul 3, 2024

Just needs a rebase.

@tlabaj tlabaj merged commit cfa3395 into patternfly:v6 Jul 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar - replace "chip" with "label" in prop language
4 participants