Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Toolbar): updated for parity with Core updates #10674

Merged
merged 9 commits into from
Jul 15, 2024

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Jun 27, 2024

What: Closes #10639

Will need to wait to pull in Core updates for modifier classes/styling.

Placeholder Codmod issue: patternfly/pf-codemods#677

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Jun 27, 2024

@thatblindgeye thatblindgeye linked an issue Jun 27, 2024 that may be closed by this pull request
4 tasks
@nicolethoen nicolethoen linked an issue Jul 1, 2024 that may be closed by this pull request
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you! Here's what I noticed.

Screenshot 2024-07-11 at 11 54 31 AM

Screenshot 2024-07-11 at 11 58 36 AM

Screenshot 2024-07-11 at 12 03 18 PM

@thatblindgeye thatblindgeye requested review from a team, tlabaj and kmcfaul and removed request for a team July 11, 2024 18:05
@thatblindgeye thatblindgeye marked this pull request as ready for review July 11, 2024 18:15
@mattnolting mattnolting self-requested a review July 11, 2024 19:13
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guy's good, LPTM. Well done @thatblindgeye 👍

@tlabaj tlabaj merged commit d508325 into patternfly:v6 Jul 15, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@tlabaj tlabaj mentioned this pull request Jul 23, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toolbar - parity with core features Toolbar followup
5 participants