Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-patternfly-react): update rules for eslint v9 #10743

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jul 15, 2024

What: Closes #10282

Updates PF's eslint plugin rules for eslint v9 compatibility.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 15, 2024

Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be good to add some tests to run both ESLint 8 and 9 on CI

@dlabaj dlabaj merged commit c88b15d into patternfly:main Jul 16, 2024
13 checks passed
@kmcfaul
Copy link
Contributor Author

kmcfaul commented Jul 16, 2024

Opened #10753 to track adding tests

cc @jonkoops

@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jul 31, 2024
kmcfaul added a commit that referenced this pull request Aug 8, 2024
* fix(TypeaheadSelect): Add callback on clear selection (#10719)

* fix(CodeEditor) resizeObserver resize loop (#10644)

* fix(CodeEditor) resizeObserver resize loop

* yarn

* add debounce

---------

Co-authored-by: Titani <[email protected]>

* cherry pick fix(SimpleSelect,CheckboxSelect): Handle initial selection(s)

* (Drag and drop): Updated example for multi list to use flex

* docs(Table): add Editable Table example

* fix(DragDrop): fix flexgrow type

* feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates (#10757)

* feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates

* Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx

Co-authored-by: kmcfaul <[email protected]>

---------

Co-authored-by: Titani Labaj <[email protected]>
Co-authored-by: kmcfaul <[email protected]>

* fix(TypeaheadSelect): Correctly show the newly selected item on selection (#10792)

* feat(TypeaheadSelect) Add creation options to TypeaheadSelect (#10802)

* update MultiTypeaheadSelect to use label instead of chip

* chore(deps): upgrade eslint-plugin-react to the latest (#10739)

* chore(deps): upgrade `eslint-plugin-markdown` to the latest version (#10738)

Signed-off-by: Jon Koops <[email protected]>

* resolve merge conflicts

* feat(eslint-plugin-patternfly-react): update rules for eslint v9 (#10743)

* resolve conflicts for chore(deps): upgrade ESLint to the latest version

* fix yarn lint issue

* fix yarn lint issue

* fix(TypeaheadSelect): Update input value only when appropriate (#10826)

* fix lint errors and demo-app

---------

Signed-off-by: Jon Koops <[email protected]>
Co-authored-by: Jeff Phillips <[email protected]>
Co-authored-by: Dominik Petřík <[email protected]>
Co-authored-by: kmcfaul <[email protected]>
Co-authored-by: Jon Koops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - eslint-plugin-patternfly-react - not compatible with Eslint 9
5 participants