chore(eslint-plugin)!: remove dependencies from ESLint plugin #10752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10752.surge.sh A11y report: https://patternfly-react-pr-10752-a11y.surge.sh |
jonkoops
force-pushed
the
eslint-sans-deps
branch
from
fac6286 to
aef2228
Compare
Closes patternfly#10740 BREAKING CHANGE: this removes the bundled dependencies and pre-defined rules from the ESLint 'reccomended' configuration. Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
eslint-sans-deps
branch
from
aef2228 to
6c36df4
Compare
jonkoops
commented
Aug 10, 2024
Comment on lines
+49
to
+53
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-markdown": "^5.1.0", | ||
| "eslint-plugin-prettier": "^5.1.3", | ||
| "eslint-plugin-prettier": "^5.2.1", | ||
| "eslint-plugin-react": "^7.34.2", | ||
| "eslint-plugin-react-hooks": "^4.6.2", |
There was a problem hiding this comment.
Had to move some dependencies to the root, as they are used by the linting configuration of the project.
jonkoops
commented
Aug 10, 2024
Comment on lines
-37
to
-50
|
|
||
| ### Building | ||
|
|
||
| ``` | ||
| yarn build | ||
| ``` | ||
|
|
||
| Note the build scripts for this are located in the root package.json under `yarn build`. | ||
|
|
||
| ### Publishing | ||
|
|
||
| ``` | ||
| yarn publish | ||
| ``` |
There was a problem hiding this comment.
These instructions do not apply to this package, they were likely copied from a template before, so I removed them here.
kmcfaul
approved these changes
Aug 12, 2024
I think this should not be an issue as the recommended rules from the plugin are not actually used by the configuration. |
tlabaj
approved these changes
Aug 12, 2024
|
Your changes have been released in: Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10740
BREAKING CHANGE: this removes the bundled dependencies and pre-defined rules from the ESLint 'reccomended' configuration.