fix(Wizard): only update new steps when step count changes #10779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10779.surge.sh A11y report: https://patternfly-react-pr-10779-a11y.surge.sh |
thatblindgeye
approved these changes
Jul 19, 2024
|
I opened #10781 as a followup to add tests for the behavior(s) seen in this PR and the previous PR |
tlabaj
approved these changes
Jul 19, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Fix / followup to #10748
You can compare the new behaviors against the previous PR's surge https://patternfly-react-pr-10748.surge.sh/components/wizard#enabled-on-form-validation (step navigation was not updating, and changing the age field was resetting the wizard).