Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Popper): added display styling to prevent page scroll #10797

Merged
merged 3 commits into from
Jul 24, 2024
Merged

fix(Popper): added display styling to prevent page scroll #10797

merged 3 commits into from
Jul 24, 2024

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Jul 23, 2024 •
edited
Loading

What: Closes #10790

Also goes towards #10511 that was closed by another fix

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 23, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10797.surge.sh

A11y report: https://patternfly-react-pr-10797-a11y.surge.sh

mcoker
mcoker approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested some table row actions and the menus look great - no flickering or page jumping or anything as far as I can tell!! 🥳

@thatblindgeye
Copy link
Contributor Author

Couple downsides to this:

  • Had to skip a couple of cypress tests. Testing the deprecated Dropdown itself on the preview/locally focuses things fine, but within the cypress tests they fail
  • Have to update the timeout for focusing the first menu item, as the display tweak breaks the focus management when opening a Menu Toggle via keyboard

@thatblindgeye thatblindgeye marked this pull request as ready for review July 23, 2024 18:51
@tlabaj tlabaj requested review from kmcfaul and tlabaj July 23, 2024 19:04
@tlabaj
Copy link
Contributor

tlabaj commented Jul 24, 2024

Can you link the original issue please

@kmcfaul kmcfaul merged commit 49de6eb into patternfly:main Jul 24, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

This was referenced Jul 25, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes

@tlabaj tlabaj tlabaj approved these changes

@mcoker mcoker mcoker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Table - Page/table gets auto scrolled while clicking on some row actions
5 participants
@thatblindgeye @patternfly-build @tlabaj @mcoker @kmcfaul