feat(DualListSelector): new demos and integration tests #10829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10829.surge.sh A11y report: https://patternfly-react-pr-10829-a11y.surge.sh |
adamviktora
force-pushed
the
dual-list-selector-new-demos
branch
from
206f5b8 to
eb28eee
Compare
adamviktora
changed the title
adamviktora
requested review from
a team,
wise-king-sullyman and
tlabaj
and removed request for
a team
tlabaj
requested review from
a team and
mattnolting
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10824
adds new demos to the demo app (almost 1:1 copy from DualListSelector examples)
adds new integration tests
2 tests of the
isTreevariant are disabled, found an issue with moving all items when filter is applied: Bug - DualListSelector next - isTree variant moves all items even with applied filter #10862, we should reenable these tests once the issue is resolved