Deprecate follow up #10850
Merged
Deprecate follow up #10850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-10850.surge.sh A11y report: https://patternfly-react-pr-10850-a11y.surge.sh |
tlabaj
force-pushed
the
deprecate_follow_up
branch
from
c0dcaaf to
9048f16
Compare
| @@ -69,13 +69,13 @@ xdescribe('Form Demo Test', () => { | |||
| cy.get('[aria-label="Close"]').type('{enter}'); | |||
| }); | |||
|
|
|||
| it('Verify keypress can control the multi-select-typeahead', () => { | |||
| cy.get('[id*="pf-select-toggle-id"][id*="select-multi-typeahead-typeahead"]').type('{downarrow}{downarrow}{enter}'); | |||
| xit('Verify keypress can control the multi-select-typeahead', () => { | |||
There was a problem hiding this comment.
(i disabled the select test that is not working due to this issue
Is this still the case, or would the fix Katie put in regarding the Menu/transition end event have resolved this?
There was a problem hiding this comment.
Her PR went in after I initially worked on this. I will rebase and test it.
| @@ -18,8 +18,7 @@ export interface IEditableSelectInputCell extends Omit<React.HTMLProps<HTMLEleme | |||
| event: React.MouseEvent | React.ChangeEvent, | |||
| newValue: any | any[], | |||
| rowIndex: number, | |||
| cellIndex: number, | |||
| isPlaceholder?: boolean | |||
There was a problem hiding this comment.
If we're removing this we should update the "Editable rows" example in the deprecated Table example file to remove the param and usage from the onSelect handler (~line 690)
tlabaj
force-pushed
the
deprecate_follow_up
branch
from
33f2488 to
9aba4f4
Compare
thatblindgeye
approved these changes
Sep 13, 2024
dlabaj
approved these changes
Sep 20, 2024
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10365
(i disabled the select test that is not working due to this issue menu - menu focusing issue. #10840)EditableSelectInputCell