Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MenuToggle): add placeholder support #10882

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Aug 26, 2024

What: Closes #10861

  • Adds isPlaceholder to MenuToggle
  • Adds example & test
  • Bumps core to alpha.211

@kmcfaul kmcfaul linked an issue Aug 26, 2024 that may be closed by this pull request
@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 26, 2024

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj requested a review from mcoker September 4, 2024 12:42
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kmcfaul kmcfaul force-pushed the menu-toggle-placeholder branch from 4166eef to cdd389f Compare September 5, 2024 21:15
@tlabaj tlabaj merged commit dd53ab9 into patternfly:main Sep 9, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu toggle - add support for placeholder styling
6 participants