Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Menus): added new fix for scroll jump bug #11119

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix(Menus): added new fix for scroll jump bug #11119

merged 2 commits into from
Oct 23, 2024

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #11053, closes #11020

v6 followup to #11056

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 17, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-11119.surge.sh

A11y report: https://patternfly-react-pr-11119-a11y.surge.sh

@jschuler
Copy link
Collaborator

any plans for backport to v5?

Screen.Recording.2024-10-10.at.9.47.46.AM-480p.mov

@thatblindgeye
Copy link
Contributor Author

@jschuler this was implemented in v5 in #11056

dlabaj
dlabaj approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit f19a7a5 into patternfly:main Oct 23, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes

@tlabaj tlabaj tlabaj approved these changes

@dlabaj dlabaj dlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@thatblindgeye @patternfly-build @jschuler @dlabaj @tlabaj @kmcfaul