Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tslib): lock tslib to 1.13.0 for consumers #4981

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

redallen
Copy link
Contributor

@redallen redallen commented Oct 9, 2020

What: Our semver of tslib was ^1.11.1, but version 1.14.0 recently released breaking changes that consumers might install if they don't have a lockfile. This PR pins it to the older version until the Typescript team fixes it or we upgrade to tslib 2.

Additional issues: I filed an issue upstream: microsoft/tslib#128

@redallen redallen changed the title fix(tslib): lock tslib to 1.13.0 for products fix(tslib): lock tslib to 1.13.0 for consumers Oct 9, 2020
@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 9, 2020

Copy link
Member

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@redallen redallen merged commit 3a5bf04 into patternfly:master Oct 9, 2020
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants