chore(tests): add keyboard interactivity test for button #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix broken link in contributing guidelines
|
PF4 preview: https://patternfly-react-pr-5037.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #5037 +/- ##
=======================================
Coverage 52.17% 52.17%
=======================================
Files 530 530
Lines 9766 9766
Branches 3596 3596
=======================================
Hits 5095 5095
Misses 4010 4010
Partials 661 661
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
redallen
approved these changes
Oct 20, 2020
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates cypress-tab-plugin and extends integration tests for Button component to ensure keyboard interactions work as expected. It also fixes a broken link in the contributing guidelines page.
What: Steps toward closing #3953