chore(card): add keyboard interaction a11y test, clean up docs #5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PF4 preview: https://patternfly-react-pr-5082.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #5082 +/- ##
=======================================
Coverage 52.44% 52.44%
=======================================
Files 539 539
Lines 9911 9911
Branches 3691 3691
=======================================
Hits 5198 5198
Misses 4050 4050
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
redallen
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Steps toward closing #3953
This PR adds keyboard interactivity test for Card component, ensuring its selectable and that the selected state can be trigger by keyboard events. It also cleans up the docs for Card by removing imported components that were not being used in a few of the examples.