Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(TimePicker): updated examples to TypeScript #9430

Merged

Conversation

wise-king-sullyman
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman commented Aug 1, 2023

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 1, 2023

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit to add "TimePicker" to the beginning of each export. Though if we want to stray away from including the component name that could make sense

@tlabaj tlabaj merged commit 32f6747 into patternfly:main Aug 14, 2023
10 checks passed
@wise-king-sullyman wise-king-sullyman deleted the time-picker-convert-examples-to-ts branch August 14, 2023 19:51
nicolethoen pushed a commit to Kells512/patternfly-react that referenced this pull request Sep 1, 2023
* docs(TimePicker): updated examples to TypeScript

* docs(TimePicker): added TimePicker to exported var names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time picker - convert examples to TS
5 participants