-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Card): convert Card react demos to TS #9561
Conversation
Preview: https://patternfly-react-pr-9561.surge.sh A11y report: https://patternfly-react-pr-9561-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments/pretty quick updates below. Could we also create separate files for these demos in a demos/examples/CardDemos
directory?
2596e0a
to
21e4256
Compare
e243aa0
to
f6de4eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just needs a rebase.
WIP card demo conversion chore(card): convert all demos to ts Apply function name suggestions from Eric Co-authored-by: Eric Olkowski <[email protected]> split up demos, PR feedback from Eric revert card view location and update name fix card view data paths fix tokens imports fix tokens import paths update import style to fix build fix import path add styling updates from main
What: Closes #9374
Converted remaining Card react demos to TS and fixed various linting / type errors