Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update devdependencies #9573

Merged
merged 3 commits into from
Oct 9, 2023
Merged

chore(deps): update devdependencies #9573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6f5737
chore(deps): update devdependencies
renovate[bot] Sep 27, 2023
bebd4ce
fix build errors
tlabaj Sep 27, 2023
d3e5019
fix docs build errors
tlabaj Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"@octokit/rest": "^20.0.0",
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "14.4.3",
"@types/jest": "29.5.3",
"@testing-library/user-event": "14.5.1",
"@types/jest": "29.5.5",
"@types/react": "^18",
"@types/react-dom": "^18",
"@typescript-eslint/eslint-plugin": "^5.59.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Drawer/DrawerPanelContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
'aria-labelledby'?: string;
}

export interface DrawerPanelContentProps extends React.HTMLProps<HTMLDivElement> {
export interface DrawerPanelContentProps extends Omit<React.HTMLProps<HTMLDivElement>, 'onResize'> {
/** Additional classes added to the drawer. */
className?: string;
/** ID of the drawer panel */
Expand Down Expand Up @@ -239,7 +239,7 @@
drawerRef.current.classList.remove(css(styles.modifiers.resizing));
isResizing = false;
onResize && onResize(e, currWidth, id);
setInitialVals = true;

Check warning on line 242 in packages/react-core/src/components/Drawer/DrawerPanelContent.tsx

View workflow job for this annotation

GitHub Actions / lint 

Assignments to the 'setInitialVals' variable from inside React Hook React.useCallback will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside React.useCallback
document.removeEventListener('mousemove', callbackMouseMove);
document.removeEventListener('mouseup', callbackMouseUp);
};
Expand All @@ -255,8 +255,8 @@
document.removeEventListener('touchend', callbackTouchEnd);
};

const callbackMouseMove = React.useCallback(handleMouseMove, []);

Check warning on line 258 in packages/react-core/src/components/Drawer/DrawerPanelContent.tsx

View workflow job for this annotation

GitHub Actions / lint 

React Hook React.useCallback has missing dependencies: 'handleControlMove' and 'position'. Either include them or remove the dependency array
const callbackTouchEnd = React.useCallback(handleTouchEnd, []);

Check warning on line 259 in packages/react-core/src/components/Drawer/DrawerPanelContent.tsx

View workflow job for this annotation

GitHub Actions / lint 

React Hook React.useCallback has missing dependencies: 'callbackTouchEnd', 'callbackTouchMove', 'currWidth', 'id', and 'onResize'. Either include them or remove the dependency array. If 'onResize' changes too often, find the parent component that defines it and wrap that definition in useCallback
const callbackTouchMove = React.useCallback(handleTouchMove, []);
const callbackMouseUp = React.useCallback(handleMouseup, []);

Expand Down
3 changes: 2 additions & 1 deletion packages/react-core/src/components/MultipleFileUpload/examples/MultipleFileUploadBasic.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ export const MultipleFileUploadBasic: React.FunctionComponent = () => {
const updateCurrentFiles = (files: File[]) => {
if (fileUploadShouldFail) {
const corruptedFiles = files.map((file) => ({ ...file, lastModified: 'foo' as unknown as number }));
setCurrentFiles((prevFiles) => [...prevFiles, ...corruptedFiles]);
// eslint-disable-next-line
setCurrentFiles((prevFiles) => [...prevFiles, ...corruptedFiles as any]);
} else {
setCurrentFiles((prevFiles) => [...prevFiles, ...files]);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-table/src/components/Table/Tr.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import inlineStyles from '@patternfly/react-styles/css/components/InlineEdit/inl
import { css } from '@patternfly/react-styles';
import { TableContext } from './Table';

export interface TrProps extends React.HTMLProps<HTMLTableRowElement>, OUIAProps {
export interface TrProps extends Omit<React.HTMLProps<HTMLTableRowElement>, 'onResize'>, OUIAProps {
/** Content rendered inside the <tr> row */
children?: React.ReactNode;
/** Additional classes added to the <tr> row */
Expand Down
3 changes: 1 addition & 2 deletions packages/react-table/src/deprecated/components/Table/examples/LegacyTableMisc.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,13 @@ export const LegacyTableMisc: React.FunctionComponent = () => {
repo.lastCommit
]);

const customRowWrapper: TableProps['rowWrapper'] = ({ trRef, className, rowProps, row: _row, ...props }) => {
const customRowWrapper: TableProps['rowWrapper'] = ({ trRef, className, rowProps, row: _row }) => {
const isOddRow = rowProps ? !!((rowProps.rowIndex + 1) % 2) : true;
const customStyle = {
borderLeft: '3px solid var(--pf-v5-global--primary-color--100)'
};
return (
<tr
{...props}
ref={trRef as React.LegacyRef<HTMLTableRowElement>}
className={css(className, isOddRow ? 'odd-row-class' : 'even-row-class', 'custom-static-class')}
style={isOddRow ? customStyle : {}}
Expand Down
8 changes: 2 additions & 6 deletions packages/react-table/src/deprecated/components/Table/examples/LegacyTableStripedCustomTr.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,10 @@ export const LegacyTableStripedCustomTr: React.FunctionComponent = () => {
repo.lastCommit
]);

const customRowWrapper: TableProps['rowWrapper'] = ({ trRef, className, rowProps, row: _row, ...props }) => {
const customRowWrapper: TableProps['rowWrapper'] = ({ trRef, className, rowProps, row: _row }) => {
const isOddRow = rowProps ? !!((rowProps.rowIndex + 1) % 2) : true;
return (
<tr
{...props}
ref={trRef as React.LegacyRef<HTMLTableRowElement>}
className={css(className, isOddRow && 'pf-m-striped')}
/>
<tr ref={trRef as React.LegacyRef<HTMLTableRowElement>} className={css(className, isOddRow && 'pf-m-striped')} />
);
};

Expand Down
1,106 changes: 576 additions & 530 deletions yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

Loading