Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-icons): rename custom icons #9759

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(react-icons): rename custom icons #9759

merged 1 commit into from
Oct 27, 2023

Conversation

mfrances17
Copy link
Contributor

What: Closes #9377

Summary:

  • Renaming the custom icons so they follow the icon naming convention should allow scripts like the ones in our documentation snippet to produce results consistent with what is expected.
  • The iconNames themselves are not changed, only the underlying resource names, so I don't believe this is a breaking change as originally thought. But if it is determined to be a breaking change, then we should delay this until the next breaking change release.

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 18, 2023 •
edited
Loading

Preview: https://patternfly-react-pr-9759.surge.sh

A11y report: https://patternfly-react-pr-9759-a11y.surge.sh

mcoker
mcoker approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! LGTM 👻🎃🍬

tlabaj
tlabaj approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wise-king-sullyman wise-king-sullyman merged commit a7a36e9 into patternfly:main Oct 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - [react-icons] - babel transformation error from PF provided snippet
5 participants
@mfrances17 @patternfly-build @wise-king-sullyman @mcoker @tlabaj