Rebase v6 branch #9832
Merged
Rebase v6 branch #9832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* fix(Text input): Added aria-expanded * add interface * updates from review
…rawer item read state (patternfly#9569) * fix(Notification Drawer): Added screen reader text for notification drawer item read state * fix snapshot * Update prop description * add aria-live * update snapshots
…y#9709) * feat: ability to add props to WizardFooter buttons * fix(WizardFooter): null check * fix(Wizard): simpler design of adding footer buttons props * test(Wizard): can add props to footer buttons * docs(WizardFooter): move comment so docs have correct description * refactor(WizardFooter): move FooterButtonProps to types file
* chore(Divider): update tests to new standards * changes from PR review
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…es (patternfly#9347) * bug(build): fixed built ESM files importing CJS files from react-styles * edited yarn.lock to invalidate deps cache in GH actions * excluded file extensions from react-styles path transform in ESM build * updated jest config to transform .mjs files * updated pr action to invalidate deps cache if package files added/edited * chore(deps): Add ts-node to support executing typescript files directly
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - [email protected]
…lease.4 (patternfly#9780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
…ly#9048 (patternfly#9087) * feat(Datalist): implement full page Basic demo to match HTML patternfly#9048 * fix syntax error * comments applied * comments applied * comments applied * comments applied * \xa0 comments applied * move key per review comments * address PR comments * revert change to package.json * Converted basic demo to TS --------- Co-authored-by: nicolethoen <[email protected]> Co-authored-by: Eric Olkowski <[email protected]>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lease.5 (patternfly#9806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* clean up instances of Array.apply * rename item to value
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change
* bug(ClipboardCopy): change children type to string Signed-off-by: gitdallas <[email protected]> * fix clipboardcopyexpanded to work with string children Signed-off-by: gitdallas <[email protected]> * refactor a bit * fix bad rebase --------- Signed-off-by: gitdallas <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Search Input - composable advanced search fix date * remove isFill from datePicker
…tternfly#9687) * docs(custom menu): add example with search input inline filtering * refactor(demo menu): rename to InlineSearchFilterMenuDemo
* chore(HelperText): update tests * break out helpertextitem tests, update tests * updates * fix lint
* fix(Chip): enable tooltip when chip updates * fix casting
* chore(DescriptionList): update tests * break out tests, pr feedback * updates * add autofit width mod test
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* chore(TreeView): updated tests * Added tests for TreeViewListItem * Added tests for TreeViewRoot and TreeView * Updated snapshots and queries
* chore(table) convert to TS chore(DashboardWrapper) convert to TS chore(Table) convert demos to TS delete superfluous dashboard components declare as ts files remove duplicate ids fix import errors, WIP build errors sync toolbar demo with main * update import paths * fix more import paths * try import from dist/esm * fix build * convert remaining table demos to ts, WIP draggable logic * revert col management with draggable to previous dnd implementation * align file names with demo names, cleanup types, fix TS errors in demo files * update fileNames in table.md * PR feedback from Eric * fix category dropdown * fix demos, remove table actions that do not support main purpose of column management demos * add fix for a11y tests as suggested by Eric * update toolbar snap * add param type to labelText --------- Co-authored-by: Jenny <[email protected]>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tlabaj
requested review from
wise-king-sullyman,
jenny-s51,
mfrances17 and
kmcfaul
|
Preview: https://patternfly-react-pr-9832.surge.sh A11y report: https://patternfly-react-pr-9832-a11y.surge.sh |
jenny-s51
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Exciting to review a Pentafied PR!
Verified my changes in the Table and Primary Detail demos and they look good for the most part... I'm seeing some visual discrepancies with menu toggles but it seems like those will be corrected as part of #9413.
Noting those discrepancies below for tracking purposes, otherwise LGTM 👍
wise-king-sullyman
approved these changes
Nov 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9831