Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace lodash/orderBy with Array.prototype.sort() #9944

Closed
wants to merge 1 commit into from

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Jan 8, 2024

Replaces all usage of lodash/orderBy with Array.prototype.sort(), reducing the dependency on Lodash as a whole.

Works towards closing #9942

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 8, 2024

Copy link
Member

@dlabrecq dlabrecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that lodash will still be installed via Victory. And since lodash is already installed, we have been using it throughout the charts package. I would recommend leaving the charts package as is, considering Victory's dependency.

Here are a few more places where lodash is used, below.

Screenshot 2024-01-11 at 11 04 25 AM

@jonkoops
Copy link
Contributor Author

I wasn't aware that Victory also depends on Lodash, so I logged an issue there as well FormidableLabs/victory#2711. Still, considering Lodash is no longer actively maintained, it cannot harm to remove some of the code here?

@jonkoops
Copy link
Contributor Author

Looks like the Victory project is also looking to remove Lodash from their dependencies, so this impediment will likely disappear.

Copy link

stale bot commented Mar 15, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 15, 2024
@jonkoops
Copy link
Contributor Author

Bumping as I still see no harm in getting this merged. @dlabrecq do you still feel like this needs to be held up?

@stale stale bot removed the wontfix label Mar 18, 2024
@dlabrecq
Copy link
Member

I'd prefer not make changes at this time (i.e., until Victory removes its own dependency).

@jonkoops
Copy link
Contributor Author

Closing this as I don't see a consensus on landing this.

@jonkoops jonkoops closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants