-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace lodash/orderBy
with Array.prototype.sort()
#9944
Conversation
Signed-off-by: Jon Koops <[email protected]>
Preview: https://patternfly-react-pr-9944.surge.sh A11y report: https://patternfly-react-pr-9944-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware that Victory also depends on Lodash, so I logged an issue there as well FormidableLabs/victory#2711. Still, considering Lodash is no longer actively maintained, it cannot harm to remove some of the code here? |
Looks like the Victory project is also looking to remove Lodash from their dependencies, so this impediment will likely disappear. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Bumping as I still see no harm in getting this merged. @dlabrecq do you still feel like this needs to be held up? |
I'd prefer not make changes at this time (i.e., until Victory removes its own dependency). |
Closing this as I don't see a consensus on landing this. |
Replaces all usage of
lodash/orderBy
withArray.prototype.sort()
, reducing the dependency on Lodash as a whole.Works towards closing #9942