Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Panel): consumed Penta updates #9946

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #9910

Additional issues:

@thatblindgeye thatblindgeye requested review from a team, wise-king-sullyman, tlabaj, andrew-ronaldson, lboehling and mattnolting and removed request for a team January 8, 2024 16:29
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 8, 2024

@lboehling
Copy link
Collaborator

lgtm!

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please open code mod issue for this?

@thatblindgeye
Copy link
Contributor Author

@tlabaj since we're only adding a new variant, would we need a codemod for that?

@tlabaj
Copy link
Contributor

tlabaj commented Jan 12, 2024

You are correct. No code mode needed in that case.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. thanks

@wise-king-sullyman wise-king-sullyman linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎺

@wise-king-sullyman wise-king-sullyman merged commit 6fdf5fe into patternfly:v6 Jan 17, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume core Penta updates: Panel
8 participants