feat(FormFiledGroupHeaderTitleTextObject): handle export specifier (#625

) * feat(FormFiledGroupHeaderTitleTextObject): handle export specifier * fix(FormFiledGroupHeaderTitleTextObject): cover export from Patternfly package
patternfly · Apr 22, 2024 · 35db8fd · 35db8fd
1 parent d0772b4
commit 35db8fd
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 5 deletions.
diff --git a/...iledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObject-renamed.test.ts b/...iledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObject-renamed.test.ts
@@ -9,6 +9,9 @@ ruleTester.run("formFiledGroupHeaderTitleTextObject-renamed", rule, {
     {
       code: `const titleTextObject: FormFiledGroupHeaderTitleTextObject = {text: "Some title", id: "form-field-group-header-title-text"};`,
     },
+    {
+      code: `export { FormFieldGroupHeaderTitleTextObject as TitleTextObject }`,
+    },
   ],
   invalid: [
     {
@@ -39,5 +42,29 @@ ruleTester.run("formFiledGroupHeaderTitleTextObject-renamed", rule, {
         },
       ],
     },
+    {
+      code: `import { FormFiledGroupHeaderTitleTextObject } from '@patternfly/react-core'; export { FormFiledGroupHeaderTitleTextObject as TitleTextObject }`,
+      output: `import { FormFieldGroupHeaderTitleTextObject } from '@patternfly/react-core'; export { FormFieldGroupHeaderTitleTextObject as TitleTextObject }`,
+      errors: [
+        {
+          message: errorMessage,
+          type: "ImportSpecifier",
+        },
+        {
+          message: errorMessage,
+          type: "ExportSpecifier",
+        },
+      ],
+    },
+    {
+      code: `export { FormFiledGroupHeaderTitleTextObject as TitleTextObject } from '@patternfly/react-core'`,
+      output: `export { FormFieldGroupHeaderTitleTextObject as TitleTextObject } from '@patternfly/react-core'`,
+      errors: [
+        {
+          message: errorMessage,
+          type: "ExportSpecifier",
+        },
+      ],
+    },
   ],
 });
diff --git a/...formFiledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObject-renamed.ts b/...formFiledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObject-renamed.ts
@@ -1,12 +1,15 @@
 import { AST, Rule } from "eslint";
-import { ImportSpecifier, Identifier, Node } from "estree-jsx";
+import { ImportSpecifier, ExportSpecifier, Identifier, Node } from "estree-jsx";
 import { getFromPackage } from "../../helpers";
 
 // https://github.com/patternfly/patternfly-react/pull/10016
 module.exports = {
   meta: { fixable: "code" },
   create: function (context: Rule.RuleContext) {
-    const { imports } = getFromPackage(context, "@patternfly/react-core");
+    const { imports, exports } = getFromPackage(
+      context,
+      "@patternfly/react-core"
+    );
 
     const previousName = "FormFiledGroupHeaderTitleTextObject";
     const newName = "FormFieldGroupHeaderTitleTextObject";
@@ -15,7 +18,11 @@ module.exports = {
       (specifier) => specifier.imported.name === previousName
     );
 
-    if (!interfaceImport) {
+    const interfaceExport = exports.find(
+      (specifier) => specifier.local.name === previousName
+    );
+
+    if (!interfaceImport && !interfaceExport) {
       return {};
     }
 
@@ -37,17 +44,38 @@ module.exports = {
 
     return {
       ImportSpecifier(node: ImportSpecifier) {
-        if (node.imported.name === interfaceImport.imported.name) {
+        if (
+          interfaceImport &&
+          node.imported.name === interfaceImport.imported.name
+        ) {
           callContextReport(node, node.imported);
         }
       },
+      ExportSpecifier(node: ExportSpecifier) {
+        if (interfaceExport && node.local.name === interfaceExport.local.name) {
+          callContextReport(node, node.local);
+        }
+
+        if (
+          interfaceImport &&
+          !hasAlias(interfaceImport) &&
+          node.local.name === previousName
+        ) {
+          callContextReport(node, node.local);
+        }
+      },
       TSTypeReference(node: { typeName: Identifier }) {
-        if (!hasAlias(interfaceImport) && node.typeName.name === previousName) {
+        if (
+          interfaceImport &&
+          !hasAlias(interfaceImport) &&
+          node.typeName.name === previousName
+        ) {
           callContextReport(node as unknown as Node, node.typeName);
         }
       },
       TSInterfaceHeritage(node: { expression: Identifier }) {
         if (
+          interfaceImport &&
           !hasAlias(interfaceImport) &&
           node.expression.name === previousName
         ) {

diff --git a/...iledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObjectRenamedInput.tsx b/...iledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObjectRenamedInput.tsx
@@ -1,4 +1,5 @@
 import { FormFiledGroupHeaderTitleTextObject } from "@patternfly/react-core";
+export { FormFiledGroupHeaderTitleTextObject as HeaderTitleObject } from "@patternfly/react-core";
 
 interface MyExtension extends FormFiledGroupHeaderTitleTextObject {}
 

diff --git a/...ledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObjectRenamedOutput.tsx b/...ledGroupHeaderTitleTextObjectRenamed/formFiledGroupHeaderTitleTextObjectRenamedOutput.tsx
@@ -1,4 +1,5 @@
 import { FormFieldGroupHeaderTitleTextObject } from "@patternfly/react-core";
+export { FormFieldGroupHeaderTitleTextObject as HeaderTitleObject } from "@patternfly/react-core";
 
 interface MyExtension extends FormFieldGroupHeaderTitleTextObject {}