PR feedback

patternfly · May 23, 2024 · 8f72511 · 8f72511
1 parent 4c32f47
commit 8f72511
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/...ds/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.test.ts b/...ds/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.test.ts
@@ -117,5 +117,33 @@ ruleTester.run("emptyState-nonExported-components", rule, {
         },
       ],
     },
+    {
+      code: `import { EmptyStateHeader } from '@patternfly/react-core';export default EmptyStateHeader;`,
+      output: `import { EmptyStateHeader } from '@patternfly/react-core';`,
+      errors: [
+        {
+          message: `EmptyStateHeader is no longer exported by PatternFly. This rule will not fix any imports, as our cleanup rule handles removal of unused imports.`,
+          type: "ImportSpecifier",
+        },
+        {
+          message: `EmptyStateHeader is no longer exported by PatternFly.`,
+          type: "ExportDefaultDeclaration",
+        },
+      ],
+    },
+    {
+      code: `import { EmptyStateHeader as CustomHeader } from '@patternfly/react-core';export default CustomHeader;`,
+      output: `import { EmptyStateHeader as CustomHeader } from '@patternfly/react-core';`,
+      errors: [
+        {
+          message: `EmptyStateHeader is no longer exported by PatternFly. This rule will not fix any imports, as our cleanup rule handles removal of unused imports.`,
+          type: "ImportSpecifier",
+        },
+        {
+          message: `CustomHeader is no longer exported by PatternFly.`,
+          type: "ExportDefaultDeclaration",
+        },
+      ],
+    },
   ],
 });
diff --git a/...odemods/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.ts b/...odemods/src/rules/v6/emptyStateNonExportedComponents/emptyState-nonExported-components.ts
@@ -1,7 +1,6 @@
 import { Rule } from "eslint";
 import {
   ImportSpecifier,
-  ExportSpecifier,
   ExportNamedDeclaration,
   ExportDefaultDeclaration,
 } from "estree-jsx";
@@ -97,9 +96,7 @@ module.exports = {
         const exportName =
           node.declaration.type === "Identifier" && node.declaration.name;
         const isEmptyStateDefaultExport = emptyStateImports.some(
-          (imp) =>
-            node.declaration.type === "Identifier" &&
-            imp.local.name === exportName
+          (imp) => imp.local.name === exportName
         );
 
         if (isEmptyStateDefaultExport) {