-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(Button): Rename isActive to isClicked (#567)
- Loading branch information
1 parent
98438dc
commit c3416bb
Showing
5 changed files
with
60 additions
and
0 deletions.
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
...-plugin-pf-codemods/src/rules/v6/buttonRenameIsActive/button-rename-isActive.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
### button-rename-isActive [(#9934)](https://github.com/patternfly/patternfly-react/pull/9934) | ||
|
||
isActive prop for Button has been renamed to isClicked | ||
|
||
#### Examples | ||
|
||
In: | ||
|
||
```jsx | ||
%inputExample% | ||
``` | ||
|
||
Out: | ||
|
||
```jsx | ||
%outputExample% | ||
``` | ||
|
25 changes: 25 additions & 0 deletions
25
...slint-plugin-pf-codemods/src/rules/v6/buttonRenameIsActive/button-rename-isActive.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
const ruleTester = require("../../ruletester"); | ||
import * as rule from "./button-rename-isActive"; | ||
|
||
ruleTester.run("button-rename-isActive", rule, { | ||
valid: [ | ||
{ | ||
code: `<Button isActive />`, | ||
}, | ||
{ | ||
code: `import { Button } from '@patternfly/react-core'; <Button someOtherProp />`, | ||
}, | ||
], | ||
invalid: [ | ||
{ | ||
code: `import { Button } from '@patternfly/react-core'; <Button isActive />`, | ||
output: `import { Button } from '@patternfly/react-core'; <Button isClicked />`, | ||
errors: [ | ||
{ | ||
message: `isActive prop for Button has been renamed to isClicked`, | ||
type: "JSXOpeningElement", | ||
}, | ||
], | ||
}, | ||
], | ||
}); |
11 changes: 11 additions & 0 deletions
11
...ges/eslint-plugin-pf-codemods/src/rules/v6/buttonRenameIsActive/button-rename-isActive.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { renameProps } from "../../helpers"; | ||
|
||
// https://github.com/patternfly/patternfly-react/pull/9934 | ||
module.exports = { | ||
meta: { fixable: "code" }, | ||
create: renameProps({ | ||
Button: { | ||
isActive: "isClicked", | ||
}, | ||
}), | ||
}; |
3 changes: 3 additions & 0 deletions
3
...eslint-plugin-pf-codemods/src/rules/v6/buttonRenameIsActive/buttonRenameIsActiveInput.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { Button } from "@patternfly/react-core"; | ||
|
||
export const ButtonRenameIsActiveInput = () => <Button isActive />; |
3 changes: 3 additions & 0 deletions
3
...slint-plugin-pf-codemods/src/rules/v6/buttonRenameIsActive/buttonRenameIsActiveOutput.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { Button } from "@patternfly/react-core"; | ||
|
||
export const ButtonRenameIsActiveInput = () => <Button isClicked />; |