Skip to content

Commit

Permalink
feat(Button): Rename isActive to isClicked (#567)
Browse files Browse the repository at this point in the history
  • Loading branch information
wise-king-sullyman authored Feb 27, 2024
1 parent 98438dc commit c3416bb
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
### button-rename-isActive [(#9934)](https://github.com/patternfly/patternfly-react/pull/9934)

isActive prop for Button has been renamed to isClicked

#### Examples

In:

```jsx
%inputExample%
```

Out:

```jsx
%outputExample%
```

Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
const ruleTester = require("../../ruletester");
import * as rule from "./button-rename-isActive";

ruleTester.run("button-rename-isActive", rule, {
valid: [
{
code: `<Button isActive />`,
},
{
code: `import { Button } from '@patternfly/react-core'; <Button someOtherProp />`,
},
],
invalid: [
{
code: `import { Button } from '@patternfly/react-core'; <Button isActive />`,
output: `import { Button } from '@patternfly/react-core'; <Button isClicked />`,
errors: [
{
message: `isActive prop for Button has been renamed to isClicked`,
type: "JSXOpeningElement",
},
],
},
],
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { renameProps } from "../../helpers";

// https://github.com/patternfly/patternfly-react/pull/9934
module.exports = {
meta: { fixable: "code" },
create: renameProps({
Button: {
isActive: "isClicked",
},
}),
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { Button } from "@patternfly/react-core";

export const ButtonRenameIsActiveInput = () => <Button isActive />;
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { Button } from "@patternfly/react-core";

export const ButtonRenameIsActiveInput = () => <Button isClicked />;

0 comments on commit c3416bb

Please sign in to comment.