Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masthead -Updates for Mastheads new structure #718

Closed
tlabaj opened this issue Jul 26, 2024 · 0 comments · Fixed by #730
Closed

Masthead -Updates for Mastheads new structure #718

tlabaj opened this issue Jul 26, 2024 · 0 comments · Fixed by #730
Assignees
@wise-king-sullyman
Labels
codemod
Milestone
Penta beta release

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Jul 26, 2024

Follow up to breaking change PR patternfly/patternfly-react#10809

The structure os the Masthead has changed. The code mode should do the following in ORder

  1. Renamed MastheadBrand to MastheadLogo
  2. Renamed MastheadMain to MastheadBrand
  3. Wrap MastheadToggle and MastheadBrand in MastheadMain

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@tlabaj tlabaj added the codemod label Jul 26, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 26, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Jul 26, 2024
@tlabaj tlabaj mentioned this issue Jul 26, 2024
Merged
@wise-king-sullyman wise-king-sullyman self-assigned this Jul 29, 2024
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to In Progress in PatternFly Issues Jul 30, 2024
This was referenced Jul 31, 2024
Merged
Merged
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Aug 5, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

feat(Masthead): Update structure wise-king-sullyman/pf-codemods
2 participants
@wise-king-sullyman @tlabaj