Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Masthead): Updates for new masthead structure in Penta #10809

Merged
merged 7 commits into from
Jul 29, 2024
Merged

feat(Masthead): Updates for new masthead structure in Penta #10809

merged 7 commits into from
Jul 29, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Jul 26, 2024 •
edited
Loading

What: Closes #10788

  • Renamed MastheadBrand to MastheadLogo
  • Renamed MastheadMain to MastheadBrand
  • Wrap MastheadToggle and MastheadBrand in MastheadMain

Codemod issue: patternfly/pf-codemods#718

@tlabaj tlabaj requested review from srambach, andrew-ronaldson, a team, wise-king-sullyman and kmcfaul and removed request for a team July 26, 2024 00:02
@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 26, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10809.surge.sh

A11y report: https://patternfly-react-pr-10809-a11y.surge.sh

@tlabaj tlabaj mentioned this pull request Jul 26, 2024
Closed
@tlabaj tlabaj linked an issue Jul 26, 2024 that may be closed by this pull request
Masthead - updates to support better logo layout #10788
Closed
srambach
srambach reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surge is down so I haven't run it yet but had a couple of questions. Otherwise looks good on inspection!

packages/react-core/src/components/Masthead/examples/Masthead.md Outdated Show resolved Hide resolved
packages/react-core/src/components/Page/examples/Page.md Outdated Show resolved Hide resolved
packages/react-integration/demo-app-ts/src/components/demos/MastheadDemo/MastheadDemo.tsx Show resolved Hide resolved
@tlabaj tlabaj requested a review from edonehoo July 26, 2024 14:08
edonehoo
edonehoo requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since surge is down, this is going off the file changes as best I can. can re-review if/when surge comes back to make sure I checked everything, but this probably covers the main things regardless!

packages/react-core/src/components/Masthead/examples/Masthead.md Outdated Show resolved Hide resolved
packages/react-core/src/components/Masthead/examples/Masthead.md Outdated Show resolved Hide resolved
packages/react-core/src/components/Page/examples/Page.md Outdated Show resolved Hide resolved
@tlabaj tlabaj requested review from edonehoo and srambach July 26, 2024 17:32
kmcfaul
kmcfaul approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. We may want to open a follow up in org if we don't already have one to update the structure for the docs site (the surge masthead is the old structure still).

andrew-ronaldson
andrew-ronaldson approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

srambach
srambach approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ⭐

@srambach srambach merged commit 266ee47 into patternfly:v6 Jul 29, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@tlabaj tlabaj mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edonehoo edonehoo edonehoo approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@kmcfaul kmcfaul kmcfaul approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

@srambach srambach srambach approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Masthead - updates to support better logo layout
8 participants
@tlabaj @patternfly-build @wise-king-sullyman @srambach @andrew-ronaldson @kmcfaul @thatblindgeye @edonehoo