Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add TS support #562

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

wise-king-sullyman
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman commented Feb 7, 2024

Closes #561

This does:

  • Add basic build infrastructure to support TS usage in the repo
  • Update the entire class-name-updater package to TS
  • Update the operating logic of eslint-plugin-pf-codemods to TS

This does not:

  • Update the pf-codemods package to TS, because I plan to make a new package for v6 forward to prevent breaking the pf-codemods package for v5 updates
  • Update the rules or tests in eslint-plugin-pf-codemods to TS, because we don't plan to do development on the existing rules. New rules created for, or rules copied to, v6 forward should be TS from the start.

Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thatblindgeye thatblindgeye merged commit a5e3f7c into patternfly:main Feb 13, 2024
2 checks passed
@wise-king-sullyman wise-king-sullyman deleted the add-typescript branch February 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TS support
3 participants