-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page penta updates #579
Page penta updates #579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small non-blocking comment, but overall looks great 💪
}, | ||
] | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lot of these files could use a prettier run.
8a4243b
to
8f6c997
Compare
The build issue here should be fixable after a rebase now |
8f6c997
to
26549cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few quick comments below. This can be a followup, but personally I think these 3 rules could be written as a single "pageRenameProps" (or updateProps) rule. May be worth keeping them separated for now and getting opinions from consumer on what they find easier/better, having more rules separated out or having less rules where some cover more than a single change.
@@ -0,0 +1,17 @@ | |||
### page-rename-isTertiaryNavGrouped [(#9948)](https://github.com/patternfly/patternfly-react/pull/9948) | |||
|
|||
We've renamed the \`isTertiaryNavGrouped\` prop to \`isHorizontalSubnavGrouped\`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've renamed the \`isTertiaryNavGrouped\` prop to \`isHorizontalSubnavGrouped\`. | |
We've renamed the `isTertiaryNavGrouped` prop to `isHorizontalSubnavGrouped` on Page. |
just to have the props as inline code in the README. We can leave the backticks escaped in the rule/tests, just add the "on Page." at the end of the message in those files as well.
@@ -0,0 +1,17 @@ | |||
### page-rename-isTertiaryNavWidthLimited [(#9948)](https://github.com/patternfly/patternfly-react/pull/9948) | |||
|
|||
We've renamed the \`isTertiaryNavWidthLimited\` prop to \`isHorizontalSubnavWidthLimited\`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to comment above.
@@ -0,0 +1,17 @@ | |||
### page-rename-tertiaryNav [(#9948)](https://github.com/patternfly/patternfly-react/pull/9948) | |||
|
|||
We've renamed the \`tertiaryNav\` prop to \`horizontalSubnav\`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above.
close #548