Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Checkbox/Radio): replace isLabelBeforeButton with labelPosition="start" #587

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

adamviktora
Copy link
Contributor

Closes #583

Wait until the underlying react PR patternfly/patternfly-react#10016 is approved and merged before merging this codemod PR.

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mod looks good, were you planning on doing the other breaking change from it under a different PR?

EDIT: disregard, I see you already did.

@thatblindgeye thatblindgeye merged commit 500ed7f into patternfly:main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox / Radio - replace isLabelBeforeButton with labelPosition="start"
3 participants