feat(Chip) update to deprecated path #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build issue here should be fixable after a rebase now |
Dominik-Petrik
force-pushed
the
chip-deprecated-path
branch
from
a62f2fe
to
d78538d
Compare
|
Looks like your invalid test is failing due to a line break difference |
Dominik-Petrik
force-pushed
the
chip-deprecated-path
branch
from
3661017
to
b0b0ab6
Compare
thatblindgeye
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
@wise-king-sullyman do you think we still need to add tests checking for esm imports etc similar to the v5 deprecated rules? Not for this PR but as a followup, this PR looks good to merge in as is to me.
wise-king-sullyman
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #557