feat(EmptyState): support icons passed directly to EmptyStateHeader #612
Conversation
| }; | ||
|
|
||
| const emptyStateIconComponent = iconPropIsEmptyStateIconComponent() | ||
| ? (iconPropValue as JSXElement) |
There was a problem hiding this comment.
Is this type assertion definitely valid?
There was a problem hiding this comment.
Yes, it is quite indirect, but the iconPropIsEmptyStateIconComponent function also checks that iconElementIdentifier is not undefined, which is true when iconPropValue?.type === "JSXElement".
There was a problem hiding this comment.
What if there is no EmptyStateIcon import? Would that cause emptyStateIconImport to be undefined and iconPropIsEmptyStateIconComponent to incorrectly return true (since undefined === undefined is true)?
There was a problem hiding this comment.
Oh, good catch, that could cause some trouble, thanks for finding that!
There was a problem hiding this comment.
That's what I'm here for! 🙂
| ? context | ||
| .getSourceCode() | ||
| .getText(emptyStateIconComponentIconAttribute) | ||
| : iconPropIsIconElement() | ||
| ? `icon={${iconElementIdentifier!.name}}` |
There was a problem hiding this comment.
Is there a way to refactor this logic to avoid the nested ternary?
adamviktora
force-pushed
the
empty-state-icon
branch
from
fe699ea
to
c227531
Compare
Uses helpers from #602 which should be merged first before this PR.
Closes #595