Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class-name-updater package to support v6 #620

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

jessiehuff
Copy link
Contributor

Closes #619

@jessiehuff jessiehuff changed the title WIP: Update class-name-updater package to support v6 Update class-name-updater package to support v6 Mar 26, 2024
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There's a slightly cleaner way to do the test scripts, then the only other change I would like to see is an update to the readme to mention the new CLI option.

packages/class-name-updater/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@thatblindgeye thatblindgeye merged commit 2c88f49 into patternfly:main Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

class-name-updater: Add v6 support to class-name-updater package
3 participants