Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Chip): Remove isReadOnly prop during label conversion #653

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(Chip): Remove isReadOnly prop during label conversion #653

merged 1 commit into from
Jun 3, 2024

Conversation

wise-king-sullyman
Copy link
Collaborator

Closes #634

Dominik-Petrik
Dominik-Petrik approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Dominik-Petrik Dominik-Petrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Dominik-Petrik Dominik-Petrik merged commit 7638965 into patternfly:main Jun 3, 2024
3 checks passed
@wise-king-sullyman wise-king-sullyman deleted the chip-remove-isReadOnly branch June 3, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@Dominik-Petrik Dominik-Petrik Dominik-Petrik approved these changes

@adamviktora adamviktora Awaiting requested review from adamviktora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip - isReadOnly prop does not exist on Label
3 participants
@wise-king-sullyman @thatblindgeye @Dominik-Petrik