fix(PageSection): updated logic to account for variant enum

[thatblindgeye]

Closes #633

[adamviktora]

This should also check for Literal inside JSXExpressionContainer, like variant={"dark"}

Suggested change

	if (variantProp.value.type !== "Literal" && !hasPatternFlyEnum) {
	const variantValueIsLiteral =
	variantProp.value.type === "Literal" ||
	(variantProp.value.type === "JSXExpressionContainer" &&
	variantProp.value.expression.type === "Literal");
	if (!variantValueIsLiteral && !hasPatternFlyEnum) {

[thatblindgeye]

Always forgetting this one 😆

[adamviktora]

We can remove this custom type, as the correct type is derived from context: Rule.RuleContext

Suggested change

	fix(fixer: {
	replaceText: (arg0: any, arg1: string) => any;
	}) {
	fix(fixer) {

[adamviktora]

nit: forgotten console.log

Suggested change

console.log(hasValidValue);

[adamviktora]

nit: unused import

Suggested change

	import { JSXOpeningElement, JSXAttribute } from "estree-jsx";
	import { JSXOpeningElement } from "estree-jsx";

[adamviktora]

Can we add test for the variant={"dark"}?

Suggested change

	},
	},
	{
	code: `import { PageSection } from '@patternfly/react-core'; <PageSection variant={"dark"} />`,
	output: `import { PageSection } from '@patternfly/react-core'; <PageSection />`,
	errors: [
	{
	message: `The \`variant\` prop for PageSection now only accepts a value of "default" or "secondary". Running the fix for this rule will remove the prop so it uses the default value of "default".`,
	type: "JSXOpeningElement",
	},
	],
	},

[adamviktora]

🎉