Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(noUnusedImports): Add unused import removal for v6 rules #678

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fix(noUnusedImports): Add unused import removal for v6 rules #678

merged 2 commits into from
Jul 11, 2024

Conversation

wise-king-sullyman
Copy link
Collaborator

Closes #656

thatblindgeye
thatblindgeye reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can we just add a test for multiple removals + 1 valid import, e.g. import {Foo, Bar, Baz, Thing}.... <Bar />

@thatblindgeye thatblindgeye merged commit 4b6bb1d into patternfly:main Jul 11, 2024
3 checks passed
@wise-king-sullyman wise-king-sullyman deleted the no-unused-imports-v6 branch July 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The cleanup rule which removes unused imports isn't running for the v6 codemods.
2 participants
@wise-king-sullyman @thatblindgeye