Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): Update demo to show a better example #154

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jeff-phillips-18
Copy link
Member

What

Closes #142
Closes UXDENG-217

Description

Separate demos into directories to make it easier to see what is needed for each demo.
Remove UI settings from node data (separate backend data from display data)

Type of change

  • Refactoring (no functional changes, no api changes)

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great improvements to logic and readability 🎉

@jeff-phillips-18 jeff-phillips-18 merged commit db31414 into patternfly:main Mar 1, 2024
7 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the cleanup-demo branch March 1, 2024 12:17
Copy link

github-actions bot commented Mar 7, 2024

🎉 This PR is included in version 5.3.0-prerelease.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean Up Pipelines Demo in Demo App
3 participants