Update demo readme and main readme #266
Merged
+10
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbravo2
commented
Jan 6, 2025
| 'do-not-delete', | ||
| { name: 'main', channel: 'prerelease', prerelease: 'prerelease' }, | ||
| ], | ||
| branches: ['do-not-delete', { name: 'main', channel: 'prerelease', prerelease: 'prerelease' }], |
There was a problem hiding this comment.
prettier build from a previous build asked me to make this change in this stage of CI:
yarn run v1.22.22
$ eslint . --ext .js,.jsx,.ts,.tsx --color
/home/runner/work/react-topology/react-topology/packages/module/release.config.js
2:14 error Replace `⏎····'do-not-delete',⏎····{·name:·'main',·channel:·'prerelease',·prerelease:·'prerelease'·},⏎··` with `'do-not-delete',·{·name:·'main',·channel:·'prerelease',·prerelease:·'prerelease'·}` prettier/prettier
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
jeff-phillips-18
approved these changes
Jan 7, 2025
|
@bobbravo2 Thank you for the contribution! |
jenny-s51
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onboarding to the project, and trying out the awesome demo. Wanted to make a few small improvements to the docs.
Work left
packages/demo-app-ts/README.md, and use a link to the correct instructions instead of having 2 sets.Type of change
Screen shots / Gifs for design review
See the GitHub UI for the rich markdown previews;
https://github.com/patternfly/react-topology/blob/57765372d242b57321e6ad220ab72d9e7c42b1cb/packages/demo-app-ts/README.md
This PR should also fix the demo image being a 404: