Cleanup: Remove duplicate demos #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 27, 2023
* fix: add pf-v5-c-table__body class * after rebase
rename composable window scroller demo
wise-king-sullyman
force-pushed
the
removeDuplicateDemos
branch
from
df60a59 to
94271c0
Compare
wise-king-sullyman
approved these changes
Dec 5, 2023
jenny-s51
force-pushed
the
removeDuplicateDemos
branch
2 times, most recently
from
df60a59 to
94271c0
Compare
jenny-s51
commented
Dec 6, 2023
There was a problem hiding this comment.
Thank you @wise-king-sullyman for rebasing and fixing up the remaining TS issues.
I pulled this down and added a couple fixes to the WindowScroller example as discussed, otherwise this looks good to merge! 🚀
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR. Please do not review/merge until #19 #20 #21 #22 #25 are all merged
This PR cleans up any references to "composable" tables - once all deprecated table component instances have been removed and converted to new composable table instances, the existing "composable" demos either become duplicates or obsolete.
In this PR:
Towards #14 and #17.