Skip to content

Commit

Permalink
Merge pull request #267 from patternfly/nicolethoen-patch-1
Browse files Browse the repository at this point in the history
fix: set up npm publishing on v5 branch
  • Loading branch information
nicolethoen authored Oct 24, 2024
2 parents 68e136b + 3a178a8 commit d0fbea3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pr-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
git checkout tmp
- run: |
git rev-parse origin/main
git rev-parse origin/v5
git rev-parse HEAD
git rev-parse origin/main..HEAD
git log origin/main..HEAD --format="%b"
git rev-parse origin/v5..HEAD
git log origin/v5..HEAD --format="%b"
# Yes, we really want to checkout the PR
# Injected by generate-workflows.js
Expand Down Expand Up @@ -52,4 +52,4 @@ jobs:
name: a11y tests
- run: node .github/upload-preview.js packages/module/coverage
name: Upload a11y report
if: always()
if: always()
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
push:
branches:
- main
- v4
- v5
jobs:
call-build-lint-test-workflow:
uses: ./.github/workflows/build-lint-test.yml
Expand Down
3 changes: 1 addition & 2 deletions packages/module/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
},
"homepage": "https://github.com/patternfly/virtual-assistant#readme",
"publishConfig": {
"access": "public",
"tag": "prerelease"
"access": "public"
},
"dependencies": {
"@patternfly/react-core": "^5.1.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/module/release.config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
branches: [ 'do-not-delete', { name: 'main', channel: 'prerelease', prerelease: 'prerelease' } ],
branches: [ 'do-not-delete', { name: 'v5', channel: 'prerelease-v5', range: '5.x' } ],
analyzeCommits: {
preset: 'angular'
},
Expand All @@ -10,5 +10,5 @@ module.exports = {
'@semantic-release/npm'
],
tagFormat: 'prerelease-v${version}',
dryRun: false
};
dryRun: true
};

0 comments on commit d0fbea3

Please sign in to comment.