Travis: drop unsupported Rubies #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also: Removes an old setting from Travis. See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
HParker
reviewed
Sep 2, 2020
.travis.yml
Outdated
| @@ -21,12 +18,11 @@ env: | |||
| matrix: | |||
| exclude: | |||
| - env: HANDLER="ox" | |||
| rvm: jruby-1.7 | |||
| rvm: jruby-9.2.6.0 | |||
There was a problem hiding this comment.
I think you can safely use jruby-9 instead and travis will figure out what the current release is for you
There was a problem hiding this comment.
I have not been successful letting Travis CI's rvm pick a Ruby which does that for me.
In rvm, the information does exist. https://github.com/rvm/rvm/blob/master/config/known#L19
There was a problem hiding this comment.
Interesting, for some reason feedjira doesn't seem to mind.
https://github.com/feedjira/feedjira/blob/master/.travis.yml#L9
Either way, dropping jruby-1.7 seems like a great idea! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was inspired by the build failure in #81.
It removes the no-longer-supported Ruby versions from the Travis CI matrix.