Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insure int type for math.factorial #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ll01
Copy link

@ll01 ll01 commented Jun 19, 2022

https://bugs.python.org/issue37315
Accepting floats for math.factorial was removed. since d is either even or manipulated to be even, it should be safe to convert to an integer.
https://stackoverflow.com/questions/21753841/factorial-in-numpy-and-scipy
math.factorial and np.math.factorial is the same thing

https://bugs.python.org/issue37315
Accepting floats for math.factorial was removed. since d is either even or manipulated to be even, it should be safe to convert to an integer.
https://stackoverflow.com/questions/21753841/factorial-in-numpy-and-scipy
math.factorial and np.math.factorial is the same thing
@paulknysh
Copy link
Owner

Hi, sorry, I somehow missed this PR earlier. I also just did major code refactoring - feel free to re-open this to be in sync with updated master brach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants