Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in negotiationNeeded() when track is destroyed #1282

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix crash in negotiationNeeded() when track is destroyed #1282

merged 1 commit into from
Oct 25, 2024

Conversation

yurp
Copy link
Contributor

@yurp yurp commented Oct 25, 2024

Fix possible crash due to invoke a mid() method on released track object. See #1281 for details

@yurp yurp mentioned this pull request Oct 25, 2024
Closed
@paullouisageneau
Copy link
Owner

Thank you for the PR

@paullouisageneau paullouisageneau changed the title fix crash in impl::PeerConnection::negotiationNeeded() Fix crash in negotiationNeeded() when track is destroyed Oct 25, 2024
@paullouisageneau paullouisageneau merged commit 848befc into paullouisageneau:master Oct 25, 2024
12 checks passed
@paullouisageneau
Copy link
Owner

Released in v0.22.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullouisageneau paullouisageneau paullouisageneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurp @paullouisageneau