Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak CI versions: move the world forward #76

Merged
merged 7 commits into from
Sep 21, 2024
Merged

Tweak CI versions: move the world forward #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a131a0
Tweak CI versions: move the world forward
paulo-ferraz-oliveira Jul 10, 2024
fd5adab
Act on CI results: fix possibly failing install
paulo-ferraz-oliveira Jul 12, 2024
9e263fd
Try to install Erlang via asdf installed via Homebrew
paulo-ferraz-oliveira Jul 12, 2024
785c658
Test only for "latest", based on Renovate'able .tool-versions
paulo-ferraz-oliveira Jul 13, 2024
1ca1155
Be less demanding
paulo-ferraz-oliveira Sep 21, 2024
8704b44
Fetch as updated as possible
paulo-ferraz-oliveira Sep 21, 2024
314ca44
Also install rebar3
paulo-ferraz-oliveira Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,4 @@ A brief description of your changes.

Closes #<issue>.

- [ ] I have performed a self-review of my changes
- [ ] I have read and understood the [contributing guidelines](/paulo-ferraz-oliveira/rebar3_checkshell/blob/main/CONTRIBUTING.md)
30 changes: 6 additions & 24 deletions .github/workflows/erlang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ jobs:
windows: 2022
# renovate datasource: github-runners, depName: macos
macos: 14
# renovate datasource: github-tags, depName: erlang/rebar3
rebar3: 3.24.0

steps:
- run: echo "versions set!"
Expand All @@ -36,29 +34,10 @@ jobs:
include:
- os-base: ubuntu
os-vsn: ${{ needs.vsns.outputs.ubuntu }}
otp-version: 25
rebar3-version: ${{ needs.vsns.outputs.rebar3 }}
- os-base: ubuntu
os-vsn: ${{ needs.vsns.outputs.ubuntu }}
otp-version: 26
rebar3-version: ${{ needs.vsns.outputs.rebar3 }}
- os-base: windows
os-vsn: ${{ needs.vsns.outputs.windows }}
otp-version: 25
rebar3-version: ${{ needs.vsns.outputs.rebar3 }}
- os-base: windows
os-vsn: ${{ needs.vsns.outputs.windows }}
otp-version: 26
rebar3-version: ${{ needs.vsns.outputs.rebar3 }}
# macos, for now, is considered best-effort
- os-base: macos
os-vsn: ${{ needs.vsns.outputs.macos }}
otp-version: 25
rebar3-version: ${{ needs.vsns.outputs.rebar3 }}
- os-base: macos # macos, for now, is considered best-effort
os-vsn: ${{ needs.vsns.outputs.macos }}
otp-version: 26
rebar3-version: ${{ needs.vsns.outputs.rebar3 }}

runs-on: ${{matrix.os-base}}-${{matrix.os-vsn}}

Expand All @@ -68,12 +47,15 @@ jobs:
- uses: erlef/setup-beam@b9c58b0450cd832ccdb3c17cc156a47065d2114f # v1.18.1
id: setup-beam
with:
otp-version: ${{matrix.otp-version}}
rebar3-version: ${{matrix.rebar3-version}}
version-type: strict
version-file: .tool-versions
if: ${{matrix.os-base != 'macos'}}

- run: |
brew install erlang@${{matrix.otp-version}}
# there be dragons
brew update
erlang=$(< .tool-versions grep erlang | sed -E 's/erlang ([^\.]+).*/\1/g')
brew install "erlang@${erlang}"
brew install rebar3
Copy link

@carlocab carlocab Sep 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that you should brew link --overwrite --force "erlang@{erlang}" to ensure that it's using the version of Erlang that you want. (Anything older than erlang@27 will not be in PATH.)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the heads up. 👍

if: ${{matrix.os-base == 'macos'}}

Expand Down