Fixed a bug in setOptions method

paulosabayomi · Mar 6, 2024 · e3b970e · e3b970e
1 parent 96313de
commit e3b970e
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,12 @@
 # Changelog
 
+## 1.1.4 (2024-03-05)
+
+- Fix: A bug caused by trying to update `_custupDefaultUploadSentence` option in `setOptions` method.
+
 ## 1.1.3 (2024-03-05)
 
-Fix: Corrected the type mistake made in version 1.1.2 by removing `targetRootElement`, it is now optional in type but still required by CustUp.
+- Fix: Corrected the type mistake made in version 1.1.2 by removing `targetRootElement`, it is now optional in type but still required by CustUp.
 
 ## 1.1.2 (2024-03-05)
 

diff --git a/core/custupCore.d.ts b/core/custupCore.d.ts
@@ -229,6 +229,13 @@ export default class CustUpCore extends EventTarget {
         link: string;
         clipboard: string;
         google_drive: string;
+        /**
+         * @protected @method show_message
+         * @param {string} msg
+         * @param {"error" | "success" | "info"} type
+         * @param {boolean} async - for async messages that doesn't hide until the request is done
+         * @param {number} timeout - timeout for hiding the message
+         */
         dropbox: string;
         box_icon: string;
         onedrive: string;

diff --git a/core/custupCore.d.ts.map b/core/custupCore.d.ts.map
diff --git a/core/custupCore.js b/core/custupCore.js
@@ -528,8 +528,6 @@ export default class CustUpCore extends EventTarget {
                 this.load_default_files();                
             }else if (key === 'default_icons_override') {
                 this.map_override_icons_to_default_icons();
-            }else if (key === '_custupDefaultUploadSentence') {
-                this.uploadSentenceEl.innerHTML = this.options._custupDefaultUploadSentence;
             }else if (key === "default_styles_override" || key === "persist_styles_override_across_instances") {
                 this.map_override_styles_to_default_styles();
             }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "custup",
-  "version": "1.1.3",
+  "version": "1.1.4",
   "description": "Highly customisable file upload library with zero dependencies",
   "main": "src/custup.min.js",
   "scripts": {

diff --git a/src/custup.min.js b/src/custup.min.js